You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/21 01:07:56 UTC

[GitHub] [apisix-dashboard] zaunist commented on pull request #2330: fix(import routes): merge route when route have the same name

zaunist commented on pull request #2330:
URL: https://github.com/apache/apisix-dashboard/pull/2330#issuecomment-1046374614


   > > Hi, I'm not sure if it's appropriate to merge based on `name`, as far as I understand it, ID should be the basis for merging, and sometimes even when there is overlapping content, no data should be merged.
   > 
   > @bzp2010 When creating a new route, the name cannot be the same, or else it will throw an error. So I merge routes based on name, Because duplicated name was treated as dirty data.
   
   Could we use based on ID ? I think ID is better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org