You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "MarcusSorealheis (via GitHub)" <gi...@apache.org> on 2023/02/19 18:27:00 UTC
[GitHub] [lucene] MarcusSorealheis opened a new pull request, #12159: remove the now unused class pointInPolygon.
MarcusSorealheis opened a new pull request, #12159:
URL: https://github.com/apache/lucene/pull/12159
### Description
I was looking into the various data structures and the tessellation bits for geo spatial and noticed that the `pointInPolygon` class was lingering in the code base. I don't believe it is used anywhere in any query plan or test. I think it's safe/wise to remove it. Feel free to close this if my analysis on its use is inaccurate. I did not see anything that struck me as a reason to keep it.
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] erikhatcher commented on pull request #12159: Remove the Now Unused Class `pointInPolygon`.
Posted by "erikhatcher (via GitHub)" <gi...@apache.org>.
erikhatcher commented on PR #12159:
URL: https://github.com/apache/lucene/pull/12159#issuecomment-1464504770
Looks good to me. Eagle eye Marcus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] nknize commented on pull request #12159: Remove the Now Unused Class `pointInPolygon`.
Posted by "nknize (via GitHub)" <gi...@apache.org>.
nknize commented on PR #12159:
URL: https://github.com/apache/lucene/pull/12159#issuecomment-1468185780
> Awesome. Thanks all for the review.
>
> The main branch is protected. I cannot merge anything myself. Has to be a committer, I believe, even after approval.
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on pull request #12159: Remove the Now Unused Class `pointInPolygon`.
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on PR #12159:
URL: https://github.com/apache/lucene/pull/12159#issuecomment-1465007588
Awesome. Thanks all for the review.
The main branch is protected. I cannot merge anything myself. Has to be a committer, I believe, even after approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] nknize merged pull request #12159: Remove the Now Unused Class `pointInPolygon`.
Posted by "nknize (via GitHub)" <gi...@apache.org>.
nknize merged PR #12159:
URL: https://github.com/apache/lucene/pull/12159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org