You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2019/02/19 07:42:48 UTC

[GitHub] [incubator-dubbo] beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

I re-examine the code, and I apologize for my mis-interpretation for 

```java
            if (invokerUrls.isEmpty() && this.cachedInvokerUrls != null) {
                invokerUrls.addAll(this.cachedInvokerUrls);
            } else {
                this.cachedInvokerUrls = new HashSet<URL>();
                this.cachedInvokerUrls.addAll(invokerUrls);//Cached invoker urls, convenient for comparison
            }
            if (invokerUrls.isEmpty()) {
                return;
            }
``` 

Dubbo doesn't have protection mechanism when empty set of addresses is pushed. We should consider it. 

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/1508 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org