You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/21 10:05:23 UTC
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9301: Add unit test for FrameworkModel/ApplicationModel/ModuleModel and add test case for ConfigManager
codecov-commenter edited a comment on pull request #9301:
URL: https://github.com/apache/dubbo/pull/9301#issuecomment-974774197
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9301](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c06e85) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3cceefa23434e1a8f337290617cb5594241b3f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cceefa) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9301 +/- ##
============================================
- Coverage 65.31% 65.22% -0.10%
+ Complexity 343 342 -1
============================================
Files 1207 1201 -6
Lines 51948 51664 -284
Branches 7724 7668 -56
============================================
- Hits 33932 33697 -235
+ Misses 14392 14336 -56
- Partials 3624 3631 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/dubbo/common/lang/ShutdownHookCallbacks.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbGFuZy9TaHV0ZG93bkhvb2tDYWxsYmFja3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...org/apache/dubbo/config/context/ConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9Db25maWdNYW5hZ2VyLmphdmE=) | `84.26% <ø> (+3.37%)` | :arrow_up: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `70.90% <100.00%> (-0.79%)` | :arrow_down: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...he/dubbo/config/context/AbstractConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9BYnN0cmFjdENvbmZpZ01hbmFnZXIuamF2YQ==) | `76.65% <100.00%> (+1.75%)` | :arrow_up: |
| [...ache/dubbo/config/context/ModuleConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9Nb2R1bGVDb25maWdNYW5hZ2VyLmphdmE=) | `68.42% <100.00%> (-1.08%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `80.00% <100.00%> (+1.34%)` | :arrow_up: |
| [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
| [...main/java/org/apache/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyLmphdmE=) | `14.28% <0.00%> (-28.58%)` | :arrow_down: |
| ... and [89 more](https://codecov.io/gh/apache/dubbo/pull/9301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cceefa...0c06e85](https://codecov.io/gh/apache/dubbo/pull/9301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org