[GitHub] [incubator-yunikorn-core] craigcondit commented on pull request #307: [YUNIKORN-807] Improve performance of node sorting.

[GitBox <gi...@apache.org>]

craigcondit commented on pull request #307:
URL: https://github.com/apache/incubator-yunikorn-core/pull/307#issuecomment-902003165


   Baseline performance (current master):
   
   ```
   [pkg/scheduler/tests] $ time (go test -bench BenchmarkScheduling -run=^$ | grep performance_test.go)
       performance_test.go:117: Total time to add 500 node in 31.182905ms, 16034.426555 per second
       performance_test.go:172: Total time to allocate 10000 containers in 27.813578526s, 359.536620 per second
       performance_test.go:117: Total time to add 1000 node in 50.780149ms, 19692.734655 per second
       performance_test.go:172: Total time to allocate 10000 containers in 56.294724715s, 177.636538 per second
       performance_test.go:117: Total time to add 2000 node in 90.955818ms, 21988.697853 per second
       performance_test.go:172: Total time to allocate 10000 containers in 1m49.266661833s, 91.519223 per second
       performance_test.go:117: Total time to add 5000 node in 254.403584ms, 19653.811166 per second
       performance_test.go:172: Total time to allocate 10000 containers in 4m57.678494932s, 33.593290 per second
   
   real	8m14.938s
   user	46m11.660s
   sys	0m20.570s
   ```
   
   B-Tree Performance (this patch):
   
   ```
   [pkg/scheduler/tests] $ time (go test -bench BenchmarkScheduling -run=^$ | grep performance_test.go)
       performance_test.go:117: Total time to add 500 node in 30.549695ms, 16366.775511 per second
       performance_test.go:172: Total time to allocate 10000 containers in 854.16043ms, 11707.402554 per second
       performance_test.go:117: Total time to add 500 node in 30.830001ms, 16217.968984 per second
       performance_test.go:172: Total time to allocate 10000 containers in 765.890195ms, 13056.701947 per second
       performance_test.go:117: Total time to add 500 node in 31.055905ms, 16099.997730 per second
       performance_test.go:172: Total time to allocate 10000 containers in 906.42909ms, 11032.302593 per second
       performance_test.go:117: Total time to add 500 node in 30.945478ms, 16157.449563 per second
       performance_test.go:172: Total time to allocate 10000 containers in 800.436131ms, 12493.189166 per second
       performance_test.go:117: Total time to add 500 node in 30.565935ms, 16358.079673 per second
       performance_test.go:172: Total time to allocate 10000 containers in 797.422808ms, 12540.398769 per second
       performance_test.go:117: Total time to add 1000 node in 51.26442ms, 19506.706601 per second
       performance_test.go:172: Total time to allocate 10000 containers in 1.344201034s, 7439.363419 per second
       performance_test.go:117: Total time to add 2000 node in 115.78496ms, 17273.400621 per second
       performance_test.go:172: Total time to allocate 10000 containers in 2.137938513s, 4677.402993 per second
       performance_test.go:117: Total time to add 5000 node in 324.152488ms, 15424.839189 per second
       performance_test.go:172: Total time to allocate 10000 containers in 3.953890445s, 2529.154548 per second
   
   real	0m40.619s
   user	10m51.105s
   sys	0m17.104s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org