You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by wa...@apache.org on 2017/08/22 23:16:05 UTC
[31/42] hadoop git commit: YARN-6908. ResourceProfilesManagerImpl is
missing @Overrides on methods (Contributed by Sunil G. via Daniel Templeton)
YARN-6908. ResourceProfilesManagerImpl is missing @Overrides on methods
(Contributed by Sunil G. via Daniel Templeton)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/5bcfe019
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/5bcfe019
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/5bcfe019
Branch: refs/heads/YARN-3926
Commit: 5bcfe01954d9bf311cd07dab20fb5999ac28271e
Parents: 740a38c
Author: Daniel Templeton <te...@apache.org>
Authored: Wed Aug 16 09:41:52 2017 -0700
Committer: Wangda Tan <wa...@apache.org>
Committed: Tue Aug 22 16:05:18 2017 -0700
----------------------------------------------------------------------
.../resource/ResourceProfilesManager.java | 34 ++++++++++++++++++++
.../resource/ResourceProfilesManagerImpl.java | 7 ++++
2 files changed, 41 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/5bcfe019/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManager.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManager.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManager.java
index af54f05..c330e25 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManager.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManager.java
@@ -18,6 +18,8 @@
package org.apache.hadoop.yarn.server.resourcemanager.resource;
+import org.apache.hadoop.classification.InterfaceAudience.Public;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.yarn.api.records.Resource;
@@ -28,19 +30,51 @@ import java.util.Map;
* Interface for the resource profiles manager. Provides an interface to get
* the list of available profiles and some helper functions.
*/
+@Public
+@Unstable
public interface ResourceProfilesManager {
+ /**
+ * Method to handle all initialization steps for ResourceProfilesManager.
+ * @param config Configuration object
+ * @throws IOException when invalid resource profile names are loaded
+ */
void init(Configuration config) throws IOException;
+ /**
+ * Get the resource capability associated with given profile name.
+ * @param profile name of resource profile
+ * @return resource capability for given profile
+ */
Resource getProfile(String profile);
+ /**
+ * Get all supported resource profiles.
+ * @return a map of resource objects associated with each profile
+ */
Map<String, Resource> getResourceProfiles();
+ /**
+ * Reload profiles based on updated configuration.
+ * @throws IOException when invalid resource profile names are loaded
+ */
void reloadProfiles() throws IOException;
+ /**
+ * Get default supported resource profile.
+ * @return resource object which is default
+ */
Resource getDefaultProfile();
+ /**
+ * Get minimum supported resource profile.
+ * @return resource object which is minimum
+ */
Resource getMinimumProfile();
+ /**
+ * Get maximum supported resource profile.
+ * @return resource object which is maximum
+ */
Resource getMaximumProfile();
}
http://git-wip-us.apache.org/repos/asf/hadoop/blob/5bcfe019/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManagerImpl.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManagerImpl.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManagerImpl.java
index b5ab384..42d38b4 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManagerImpl.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceProfilesManagerImpl.java
@@ -56,6 +56,7 @@ public class ResourceProfilesManagerImpl implements ResourceProfilesManager {
private static final String[] MANDATORY_PROFILES =
{ DEFAULT_PROFILE, MINIMUM_PROFILE, MAXIMUM_PROFILE };
+ @Override
public void init(Configuration config) throws IOException {
conf = config;
loadProfiles();
@@ -146,28 +147,34 @@ public class ResourceProfilesManagerImpl implements ResourceProfilesManager {
return resource;
}
+ @Override
public Resource getProfile(String profile) {
return Resources.clone(profiles.get(profile));
}
+ @Override
public Map<String, Resource> getResourceProfiles() {
return Collections.unmodifiableMap(profiles);
}
+ @Override
@VisibleForTesting
public void reloadProfiles() throws IOException {
profiles.clear();
loadProfiles();
}
+ @Override
public Resource getDefaultProfile() {
return getProfile(DEFAULT_PROFILE);
}
+ @Override
public Resource getMinimumProfile() {
return getProfile(MINIMUM_PROFILE);
}
+ @Override
public Resource getMaximumProfile() {
return getProfile(MAXIMUM_PROFILE);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org