You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/16 17:02:47 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #10944: ARROW-13632: [C++] Fix filtering of sliced FixedSizeList array

lidavidm commented on a change in pull request #10944:
URL: https://github.com/apache/arrow/pull/10944#discussion_r689707304



##########
File path: cpp/src/arrow/compute/kernels/vector_selection_test.cc
##########
@@ -634,9 +665,19 @@ TEST_F(TestFilterKernelWithUnion, FilterUnion) {
       [2, null]
     ])");
   this->AssertFilter(union_type, union_json, "[1, 1, 1, 1, 1, 1, 1]", union_json);
+
+  // Sliced (check this manually as concatenation of dense unions isn't implemented)

Review comment:
       nit: maybe reference ARROW-4975 explicitly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org