You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/02/12 04:49:32 UTC
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local packages to distinguish easily.
### What type of PR is it?
[Improvement]
### TODOs
- [x] Add link to published npm packages
- [x] Grey color for local to distinguish
### What is the Jira issue?
[ZEPPELIN-2099](https://issues.apache.org/jira/browse/ZEPPELIN-2099)
### How should this be tested?
- Open `/helium` and click the name of package.
### Screenshots (if appropriate)
#### NPM Link
#### Local Package Name Color
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2099/adding-npm-link-to-helium-pkg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2006
----
commit 3ff460eae614290ada34ff6ad4a897e28ffd280d
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:33:49Z
feat: Add npm link for helium pkgs published in npm
commit d4ac92373b3ed2a9d12d861340703b15cbd45342
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:47:06Z
feat: Add color to local packages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@AhyoungRyu sounds good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local packages to distinguish easily.
### What type of PR is it?
[Improvement]
### TODOs
- [x] Add link to published npm packages
- [x] Grey color for local to distinguish
### What is the Jira issue?
[ZEPPELIN-2099](https://issues.apache.org/jira/browse/ZEPPELIN-2099)
### How should this be tested?
1. Build Zeppelin using ` mvn clean package -Phelium-dev-Pexamples -DskipTests;` for creating helium examples.
2. Open the `/helium` page
- click the name of published npm package.
- check color of local package.
### Screenshots (if appropriate)
#### NPM Link
#### Local Package Name Color
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2099/adding-npm-link-to-helium-pkg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2006
----
commit 3ff460eae614290ada34ff6ad4a897e28ffd280d
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:33:49Z
feat: Add npm link for helium pkgs published in npm
commit d4ac92373b3ed2a9d12d861340703b15cbd45342
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:47:06Z
feat: Add color to local packages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@1ambda Sorry for my late comment. Also can't come up with better idea than `return pkg.artifact && !pkg.artifact.includes('@');` for now \U0001f914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Thanks for reply! Then, use this logic to distinguish them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@Leemoonsoo Someday
- what about black?
- we might use labels such as `local` and `online` for helium packages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@1ambda Thanks for your effort! Tested and it works well as expected.
Maybe it's nit; these font colors are different now
- for local registry's pkg name : `#3071a9`
- for online registry's : `#428bca`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Okay, maybe then stick to black-grey, and see how it looks and improve later?
Having label sounds good as well. maybe we can try put small npm logo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Yeah looks good to me now! Before we merge this, can we handle the different font color as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2006
It's nit. I think 'grey' can give impression that something is disabled or unavailable when it is compared to 'blue'. What do you think? Will there be any better way visually distinguish package from online registry and package from local registry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@Leemoonsoo @1ambda I'm planning to make Helium packages sortable in [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109). Can I handle the further improvement that you mentioned as well? (I mean in another PR :D )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Then I'll merge this to master if there is no further discussion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2006
I didn't noticed the latest change affects to the font color that I mentioned. Tested again and I like the idea to distinguish local pkg (-> grey) and online registered one(-> blue) with color.
<img width="576" alt="screen shot 2017-02-13 at 9 26 28 pm" src="https://cloud.githubusercontent.com/assets/10060731/22883396/6f7c00f6-f233-11e6-9d82-2ea3816f6db6.png">
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@AhyoungRyu Thanks for review. I'v changed the condition for checking local package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Or are there other ways to figure out local package? instead of `return pkg.artifact && !pkg.artifact.includes('@');`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs pu...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local packages to distinguish easily.
### What type of PR is it?
[Improvement]
### TODOs
- [x] Add link to published npm packages
- [x] Grey color for local to distinguish
### What is the Jira issue?
[ZEPPELIN-2099](https://issues.apache.org/jira/browse/ZEPPELIN-2099)
### How should this be tested?
1. Build Zeppelin using ` mvn clean package -Phelium-dev-Pexamples -DskipTests;` for creating helium examples.
2. Open the `/helium` page
- click the name of published npm package.
- check color of local package.
### Screenshots (if appropriate)
#### NPM Link
#### Local Package Name Color
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2099/adding-npm-link-to-helium-pkg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2006
----
commit 3ff460eae614290ada34ff6ad4a897e28ffd280d
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:33:49Z
feat: Add npm link for helium pkgs published in npm
commit d4ac92373b3ed2a9d12d861340703b15cbd45342
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-12T04:47:06Z
feat: Add color to local packages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---