You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/08/27 22:29:22 UTC
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch/pull/93
Capture histogram data for _bulk_requests
COUCHDB-2792
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2792-bulk-requests-histo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit b93aab71c600297fc00b2754f6d2dc3abcdf7e03
Author: Robert Newson <rn...@apache.org>
Date: 2015-08-27T20:22:17Z
Capture histogram data for _bulk_requests
COUCHDB-2792
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/93#issuecomment-135567011
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/93#discussion_r38143731
--- Diff: priv/stats_descriptions.cfg ---
@@ -51,8 +51,8 @@
{desc, <<"number of _local document write operations">>}
]}.
{[couchdb, httpd, bulk_requests], [
- {type, counter},
- {desc, <<"number of bulk requests">>}
+ {type, histogram},
+ {desc, <<"distribution of bulk request sizes">>}
--- End diff --
Yeah, I'm stuck on names. The 'n' value in here is the same value as the original counter, which is why I felt the name was appropriate, it just has more information, like the distribution of the sizes of these requests. That you can have multiple things inside a _bulk_docs is what distinguishes it from most other endpoints, so I felt that implied what the histogram meant (and the description makes it explicit)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/93#discussion_r38142965
--- Diff: priv/stats_descriptions.cfg ---
@@ -51,8 +51,8 @@
{desc, <<"number of _local document write operations">>}
]}.
{[couchdb, httpd, bulk_requests], [
- {type, counter},
- {desc, <<"number of bulk requests">>}
+ {type, histogram},
+ {desc, <<"distribution of bulk request sizes">>}
--- End diff --
I think this metric should be renamed. Now it's not about how much bulk requests were made, but how many documents were passed in bulk. And request size here confusing: without reading the code I would say that this is amount of bytes passed with request.
Suggestion: `[couchdb, httpd, bulk_docs]` and `distribution of amount docs stored in bulk`.
Sounds good?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Capture histogram data for _bulk_reque...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/93#discussion_r38145911
--- Diff: priv/stats_descriptions.cfg ---
@@ -51,8 +51,8 @@
{desc, <<"number of _local document write operations">>}
]}.
{[couchdb, httpd, bulk_requests], [
- {type, counter},
- {desc, <<"number of bulk requests">>}
+ {type, histogram},
+ {desc, <<"distribution of bulk request sizes">>}
--- End diff --
Let's keep counter in additional to histogram. This shouldn't hurt, but there nobody would be confused about which field to use. Also, `n` here wouldn't be the same as old counter in case of invalid request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---