You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/07 02:24:14 UTC
[GitHub] [incubator-inlong] leezng opened a new pull request, #4545: [INLONG-4544][Dashboard] Pulsar Cluster support tenant param
leezng opened a new pull request, #4545:
URL: https://github.com/apache/incubator-inlong/pull/4545
- Fixes #4544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4545: [INLONG-4544][Dashboard] Pulsar Cluster support tenant param
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4545:
URL: https://github.com/apache/incubator-inlong/pull/4545#discussion_r890713019
##########
inlong-dashboard/src/pages/Clusters/config/Pulsar.tsx:
##########
@@ -29,9 +30,16 @@ export const Pulsar: ClsConfigItemType[] = [
{
type: 'input',
label: 'ServiceUrl',
- name: 'serviceUrl',
+ name: 'url',
Review Comment:
url
->
adminUrl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4545: [INLONG-4544][Dashboard] Pulsar Cluster support tenant param
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4545:
URL: https://github.com/apache/incubator-inlong/pull/4545#discussion_r890716537
##########
inlong-dashboard/src/pages/Clusters/config/Pulsar.tsx:
##########
@@ -29,9 +30,16 @@ export const Pulsar: ClsConfigItemType[] = [
{
type: 'input',
label: 'ServiceUrl',
- name: 'serviceUrl',
+ name: 'url',
Review Comment:
The `url` was the backend requirement, it's a general name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4545: [INLONG-4544][Dashboard] Pulsar Cluster support tenant param
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4545:
URL: https://github.com/apache/incubator-inlong/pull/4545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org