You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/26 16:31:58 UTC
[GitHub] [accumulo] keith-turner opened a new pull request, #3049: fixes #3046 limiting ample to single table
keith-turner opened a new pull request, #3049:
URL: https://github.com/apache/accumulo/pull/3049
In PR #3044 a bug was introduced that made an Ample operation that was intended to read a single tables metadata read multiple tables metadata. This change fixes that bug limiting the Ample read a to a single tables metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3049: fixes #3046 limiting ample to single table
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3049:
URL: https://github.com/apache/accumulo/pull/3049#discussion_r1005949743
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -376,7 +376,8 @@ private List<TabletMetadata> findOverlappingTablets(KeyExtent loadRange,
}
if (cmp != 0) {
- throw new IllegalStateException("Unexpected prev end row " + currTablet + " " + loadRange);
+ throw new IllegalStateException(
+ "Unexpected prev end row " + currTablet.getExtent() + " " + loadRange);
Review Comment:
Can this throw NPE? Seems like `tabletIter.next()` could be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3049: fixes #3046 limiting ample to single table
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3049:
URL: https://github.com/apache/accumulo/pull/3049#discussion_r1005951371
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -376,7 +376,8 @@ private List<TabletMetadata> findOverlappingTablets(KeyExtent loadRange,
}
if (cmp != 0) {
- throw new IllegalStateException("Unexpected prev end row " + currTablet + " " + loadRange);
+ throw new IllegalStateException(
+ "Unexpected prev end row " + currTablet.getExtent() + " " + loadRange);
Review Comment:
Nevermind, it looks like it would throw on line 374 if that were the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #3049: fixes #3046 limiting ample to single table
Posted by GitBox <gi...@apache.org>.
keith-turner merged PR #3049:
URL: https://github.com/apache/accumulo/pull/3049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org