[GitHub] [skywalking] YczYanchengzhe commented on a change in pull request #7636: Support for filter filtering of int type values

[GitBox <gi...@apache.org>]

YczYanchengzhe commented on a change in pull request #7636:
URL: https://github.com/apache/skywalking/pull/7636#discussion_r701064993



##########
File path: oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/StringMatchTest.java
##########
@@ -23,44 +23,44 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
-public class EqualMatchTest {
+public class StringMatchTest {
 
     @Test
     public void integerShouldEqualWhenLargerThan128() {
         Integer a = 334;
         Integer b = 334;
-        boolean match = new EqualMatch().match(a, b);

Review comment:
       Am I trying below whether adding the method signature can be directly supported




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org