You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/30 01:14:29 UTC

Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27363/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-884
    https://issues.apache.org/jira/browse/AURORA-884


Repository: aurora


Description
-------

Add explicit test coverage for stat gauge in TaskSchedulerImpl.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 5739c39e548092f15e50e639344e24161f6305dc 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5d12df99a29cddf97b3ef49a9de1a747c16461fe 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java fe57375c11447dd79f44e1ba0ddc3e5ca37741ea 

Diff: https://reviews.apache.org/r/27363/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27363/#review59084
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Oct. 30, 2014, 12:14 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27363/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add explicit test coverage for stat gauge in TaskSchedulerImpl.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 5739c39e548092f15e50e639344e24161f6305dc 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5d12df99a29cddf97b3ef49a9de1a747c16461fe 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java fe57375c11447dd79f44e1ba0ddc3e5ca37741ea 
> 
> Diff: https://reviews.apache.org/r/27363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27363/#review59085
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Oct. 30, 2014, 12:14 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27363/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add explicit test coverage for stat gauge in TaskSchedulerImpl.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 5739c39e548092f15e50e639344e24161f6305dc 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5d12df99a29cddf97b3ef49a9de1a747c16461fe 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java fe57375c11447dd79f44e1ba0ddc3e5ca37741ea 
> 
> Diff: https://reviews.apache.org/r/27363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27363/#review59090
-----------------------------------------------------------

Ship it!


Master (6b30cf7) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 30, 2014, 12:14 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27363/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add explicit test coverage for stat gauge in TaskSchedulerImpl.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 5739c39e548092f15e50e639344e24161f6305dc 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5d12df99a29cddf97b3ef49a9de1a747c16461fe 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java fe57375c11447dd79f44e1ba0ddc3e5ca37741ea 
> 
> Diff: https://reviews.apache.org/r/27363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>