[fineract] branch develop updated: Revert "FINERACT-1724: Fix entity reload logic of COB"

[ad...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 0e6f5eab9 Revert "FINERACT-1724: Fix entity reload logic of COB"
0e6f5eab9 is described below

commit 0e6f5eab9decfdaeb6274b1653dc1838ff83bd56
Author: Adam Saghy <ad...@gmail.com>
AuthorDate: Wed May 3 16:04:21 2023 +0200

    Revert "FINERACT-1724: Fix entity reload logic of COB"
    
    This reverts commit 5fe708a90feb3c022f7835386d045aaa18cf7d89.
---
 .../org/apache/fineract/cob/service/LoanReloadService.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java b/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
index d661bf6a0..4e86b0d01 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
@@ -18,19 +18,17 @@
  */
 package org.apache.fineract.cob.service;
 
-import javax.persistence.EntityManager;
-import javax.persistence.PersistenceContext;
 import lombok.RequiredArgsConstructor;
 import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import org.apache.fineract.portfolio.loanaccount.domain.Loan;
+import org.apache.fineract.portfolio.loanaccount.service.LoanAssembler;
 import org.springframework.stereotype.Component;
 
 @Component
 @RequiredArgsConstructor
 public class LoanReloadService implements ReloadService<Loan> {
 
-    @PersistenceContext
-    private EntityManager entityManager;
+    private final LoanAssembler loanAssembler;
 
     @Override
     public <S extends AbstractPersistableCustom> boolean canReload(S input) {
@@ -39,9 +37,7 @@ public class LoanReloadService implements ReloadService<Loan> {
 
     @Override
     public Loan reload(Loan input) {
-        entityManager.flush();
-        entityManager.refresh(input);
-        return input;
+        return loanAssembler.assembleFrom(input.getId());
     }
 
 }