[GitHub] [superset] villebro commented on a change in pull request #17303: fix: datatable crash when column is empty string

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17303:
URL: https://github.com/apache/superset/pull/17303#discussion_r740164728



##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -135,7 +135,8 @@ export const useTableColumns = (
               key =>
                 ({
                   accessor: row => row[key],
-                  Header: key,
+                  // When the key is empty, have to give a string of length greater than 1

Review comment:
       nit: "...greater than 0`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org