[jira] [Commented] (TS-1786) only enable -Werror for debug builds

["Uri Shachar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616574#comment-13616574 ] 

Uri Shachar commented on TS-1786:
---------------------------------

I'm concerned that this will make it too easy to miss/ignore problems -- how many people build with _--enable-debug_ before each commit? Out of the rest, how many would notice that the debug buildbot is failing.....
I'd suggest adding a configure.ac option to disable -Werror (something like _\--disable-werror_) - that way *all* of our buildbots will still be sensitive to compilation warnings, but users will be able to override if it causes breakage on their system.
                
> only enable -Werror for debug builds
> ------------------------------------
>
>                 Key: TS-1786
>                 URL: https://issues.apache.org/jira/browse/TS-1786
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: James Peach
>             Fix For: 3.3.3
>
>
> It's very difficult to always build with -Werror on every platform we support. -Werror is only valuable to developers, not so much for users. We should consider only enabling -Werror if the build was configured with --enable-debug. This probably involves adding autoconf macros to test whether the compiler actually supports -Werror.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira