You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Christian Cordova (Jira)" <ji...@apache.org> on 2021/07/30 18:34:00 UTC
[jira] [Commented] (ARROW-7090) [C++] AssertFieldEqual (and
friends) doesn't show metadata on failure
[ https://issues.apache.org/jira/browse/ARROW-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390737#comment-17390737 ]
Christian Cordova commented on ARROW-7090:
------------------------------------------
In https://issues.apache.org/jira/browse/ARROW-9646 new functions were added as [https://github.com/apache/arrow/pull/8066/files#diff-7ef311b16b56ffbcf5f590f9f04cfdeb5b03be9f8d5396b2d641781448c13ed5] shows. These functions ( {{ToStringwithMetadata()}} ) are enough to consider this ticket (ARROW-7090) as solved?
> [C++] AssertFieldEqual (and friends) doesn't show metadata on failure
> ---------------------------------------------------------------------
>
> Key: ARROW-7090
> URL: https://issues.apache.org/jira/browse/ARROW-7090
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Antoine Pitrou
> Assignee: Christian Cordova
> Priority: Major
>
> If two fields only differ by metadata the error message isn't very informative:
> {code}
> ../src/arrow/testing/gtest_util.cc:147: Failure
> Failed
> left field: ints: int8 not null
> right field: ints: int8 not null
> {code}
> Perhaps {{DataType::ToString}}, {{Field::ToString}} and {{Schema::ToString}} could get an optional flag to display metadata?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)