You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/29 15:08:13 UTC

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884285645


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##########
@@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBranchCreation() )
                     {
                         messageKey = getMapversionPromptKey( releaseDescriptor );
                     }
-                    String message =
-                            MessageFormat.format( resourceBundle.getString( messageKey ), project.getName(),
-                                    projectId );
+                    String message = MessageFormat.format( resourceBundle.getString( messageKey ), project.getName(),

Review Comment:
   this can be a simplification for later, why not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org