You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ssudhakaran <gi...@git.apache.org> on 2017/02/13 23:47:50 UTC
[GitHub] qpid-proton-j pull request #4: SSLContext changes
GitHub user ssudhakaran opened a pull request:
https://github.com/apache/qpid-proton-j/pull/4
SSLContext changes
related JIRA
https://issues.apache.org/jira/browse/PROTON-1405
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssudhakaran/qpid-proton-j master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton-j/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 37ba26b0345a53bf318a434e0a871019b27fa004
Author: Shibi <ss...@paypal.com>
Date: 2017-02-12T03:37:45Z
SSLContext changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #4: SSLContext changes
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/4
Actually, if you could also confirm if its just working for you that would be good too, as I can then look to kick off the release process on 0.18.0 some time, perhaps next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #4: SSLContext changes
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/4
I've pushed an updated set of changes, to address some of my earlier feedback and some issues with the subsequent commit. Give things a try out on master and comment here or on PROTON-1405 if you have any issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j pull request #4: SSLContext changes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton-j/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #4: SSLContext changes
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/4
I've had a look and have some comments:
- The changes should inclulde some tests for the new feature.
- The setter javadoc should make clear that this overrides any other configuration that might have otherwise been uesd to create a context, and the getter only returns anything set with the setter.
- The changes introduce various lines with whitespace errors (lines with only spaces, mixtures of tabs and space indents). Please ensure you use spaces only, and empty lines are in fact empty.
- The change in IoHandler to force EXTERNAL is unrelated and not required here, please remove it.
Some pointers for any updates and future PRs (info which I'll add to the website/repo's at some point soon, so folks can see it in advance, or we can reference it later):
- If you raise the PR with the JIRA key in the title (e.g. see #3), a bot will raise a note against the JIRA for open/close and also relay future comments to the JIRA.
- Similarly if you could include the key in the commit log message, that way a bot records it on the JIRA upon eventual commit.
- In general PRs should be a single commit rebased to sit at the HEAD of the current master, without any merge commits. Multiple commits can be useful if its a many-layered change and the steps help evaluate it however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org