You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/20 18:07:47 UTC
[GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #24:
[MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28
hazendaz commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28
URL: https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-576381801
I'm not sure I entirely follow. Everyone is already told to override checkstyle for updates and adjust config if they override defaults. This ensures the build is compliant with 8.28 and binary was set to 8.28. That way anyone running into config issues see what was done here. Do you mean the fact no new tests for any newer features? Are those required of this PR? I think that would be a separate PR.
If 3.1.1 release is in flight this can come later.
Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Enrico Olivelli <no...@github.com>
Sent: Monday, January 20, 2020 11:32:44 AM
To: apache/maven-checkstyle-plugin <ma...@noreply.github.com>
Cc: Jeremy Landis <je...@hotmail.com>; Author <au...@noreply.github.com>
Subject: Re: [apache/maven-checkstyle-plugin] [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28 (#24)
I am not sure we should merge this change now that we are cutting 3.1.1
this release wants to open the way to using latest Checkstyle but without updating checkstyle itself
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/maven-checkstyle-plugin/pull/24?email_source=notifications&email_token=AAHODI2WQ4Z3RAVJVAU5VUDQ6XG2ZA5CNFSM4KI666OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNGG4Q#issuecomment-576349042>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI4LSAVWKTP4KID6PU3Q6XG2ZANCNFSM4KI666OA>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services