You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Peter Lee (Jira)" <ji...@apache.org> on 2021/06/01 09:28:00 UTC
[jira] [Commented] (COMPRESS-581) Make getLocalHeaderOffset()
public
[ https://issues.apache.org/jira/browse/COMPRESS-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354964#comment-17354964 ]
Peter Lee commented on COMPRESS-581:
------------------------------------
Hi [~franckval]
I think it's not a good idea to make _getLocalHeaderOffset_ public.
Most users of Commons Compress are not familiar with Zip specification. They have no ideas about Local File Header. We should avoid the implemention details.
If you do need to get the LFH offset, you can get it via debug - I think this is enough for zip file analysises.
> Make getLocalHeaderOffset() public
> ----------------------------------
>
> Key: COMPRESS-581
> URL: https://issues.apache.org/jira/browse/COMPRESS-581
> Project: Commons Compress
> Issue Type: Wish
> Affects Versions: 1.20
> Reporter: Franck Valentin
> Priority: Minor
>
> Hi,
> I use this library to analyse zip files and get the entries and to do so I need to get the entries together with their offsets within the archive. I use ZipArchiveEntry but the issue is that getLocalHeaderOffset() is protected instead of being public.
> Looking at the source code I don't understand the reason behind it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)