You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2007/05/18 10:28:16 UTC
[jira] Created: (HADOOP-1387) FindBugs -> Performance
FindBugs -> Performance
------------------------
Key: HADOOP-1387
URL: https://issues.apache.org/jira/browse/HADOOP-1387
Project: Hadoop
Issue Type: Bug
Components: mapred
Affects Versions: 0.12.3
Reporter: Arun C Murthy
Assigned To: Arun C Murthy
Fix For: 0.14.0
Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1387) FindBugs -> Performance
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-1387:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Arun!
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch, HADOOP-1387_2_20070519.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1387) FindBugs -> Performance
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-1387:
----------------------------------
Attachment: HADOOP-1387_2_20070519.patch
Good catch Raghu... fixed now. Thanks!
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch, HADOOP-1387_2_20070519.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1387) FindBugs -> Performance
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496983 ]
Raghu Angadi commented on HADOOP-1387:
--------------------------------------
I just took a quick look to see what kind of changes go into FindBug fixes.
regd :
{code}
--- src/webapps/job/analysejobhistory.jsp (revision 539486)
+++ src/webapps/job/analysejobhistory.jsp (working copy)
@@ -82,8 +82,8 @@
}
Comparator<JobHistory.Task> cMap = new Comparator<JobHistory.Task>(){
public int compare(JobHistory.Task t1, JobHistory.Task t2){
- Long l1 = new Long(t1.getLong(Keys.FINISH_TIME) - t1.getLong(Keys.START_TIME));
- Long l2 = new Long(t2.getLong(Keys.FINISH_TIME) - t2.getLong(Keys.START_TIME)) ;
+ Long l1 = t1.getLong(Keys.FINISH_TIME) - t1.getLong(Keys.START_TIME);
+ Long l2 = t2.getLong(Keys.FINISH_TIME) - t2.getLong(Keys.START_TIME);
return l2.compareTo(l1);
}
};
{code}
Does this reduce an allocation? Should it be: {{long l1 = ...; long l2 = ...;}} .
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1387) FindBugs -> Performance
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496924 ]
Hadoop QA commented on HADOOP-1387:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12357639/HADOOP-1387_1_20070518.patch applied and successfully tested against trunk revision r539243.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/159/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/159/console
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1387) FindBugs -> Performance
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-1387:
----------------------------------
Status: Patch Available (was: Open)
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1387) FindBugs -> Performance
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-1387:
----------------------------------
Attachment: HADOOP-1387_1_20070518.patch
Attached patch fixes 57 out of the 105 'Performance' issues as noted by findbugs... basically everything in mapred (and some related to SequenceFile) .
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1387) FindBugs -> Performance
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497823 ]
Hadoop QA commented on HADOOP-1387:
-----------------------------------
Integrated in Hadoop-Nightly #97 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/97/)
> FindBugs -> Performance
> ------------------------
>
> Key: HADOOP-1387
> URL: https://issues.apache.org/jira/browse/HADOOP-1387
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Arun C Murthy
> Assigned To: Arun C Murthy
> Fix For: 0.14.0
>
> Attachments: HADOOP-1387_1_20070518.patch, HADOOP-1387_2_20070519.patch
>
>
> Fix the 'Performance' bugs shown up by findbugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.