You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/04/12 16:44:53 UTC
Review Request 46096: Updated prepare() method of "network/cni"
isolator for tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46096/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan and Jie Yu.
Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167
Repository: mesos
Description
-------
Updated prepare() method of "network/cni" isolator for tests.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c
Diff: https://reviews.apache.org/r/46096/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 46096: Updated prepare() method of "network/cni"
isolator for tests.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46096/
-----------------------------------------------------------
(Updated April 26, 2016, 11:53 p.m.)
Review request for mesos, Avinash sridharan and Jie Yu.
Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167
Repository: mesos
Description
-------
Updated prepare() method of "network/cni" isolator for tests.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ef0bc1092d761804ca6bd73016c0f3dd23719257
Diff: https://reviews.apache.org/r/46096/diff/
Testing
-------
make check
Thanks,
Qian Zhang
Re: Review Request 46096: Updated prepare() method of "network/cni"
isolator for tests.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46096/#review129961
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 529)
<https://reviews.apache.org/r/46096/#comment193524>
We don't need this variable. It's being used only at one location, we can simply do (name == ....) .
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 580)
<https://reviews.apache.org/r/46096/#comment193526>
Can we do :
// In test mode, we will not create a new network namespace for the container. The container will be launched in the host's network namespace. We will use a mock-plugin for the test to return the host's ip address for this test container.
- Avinash sridharan
On April 12, 2016, 2:45 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46096/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 2:45 p.m.)
>
>
> Review request for mesos, Avinash sridharan and Jie Yu.
>
>
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated prepare() method of "network/cni" isolator for tests.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c
>
> Diff: https://reviews.apache.org/r/46096/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 46096: Updated prepare() method of "network/cni"
isolator for tests.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46096/
-----------------------------------------------------------
(Updated April 12, 2016, 10:45 p.m.)
Review request for mesos, Avinash sridharan and Jie Yu.
Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167
Repository: mesos
Description
-------
Updated prepare() method of "network/cni" isolator for tests.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c
Diff: https://reviews.apache.org/r/46096/diff/
Testing (updated)
-------
make check
Thanks,
Qian Zhang