[jira] [Commented] (AIRFLOW-1061) Log URL in Task Instance list is incorrect when running locally

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927770#comment-16927770 ] 

ASF GitHub Bot commented on AIRFLOW-1061:
-----------------------------------------

stale[bot] commented on pull request #2798: [AIRFLOW-1061] Remove BASE_URL from log_url and mark_success_url
URL: https://github.com/apache/airflow/pull/2798
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Log URL in Task Instance list is incorrect when running locally
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-1061
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1061
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Nicholas Duffy
>            Priority: Major
>
> The Log URL in the Task Instance list links to BASE_URL + /admin/airflow/log (https://github.com/apache/incubator-airflow/blob/d8c0f59d5d627efb65b47264d5169e3626195839/airflow/models.py#L936) while it should link to only /admin/airflow/log.
> The current behavior causes the link to be incorrect if you are running Airflow locally. 
> Example:
> - Running Airflow on Vagrant on my local machine
> - URL is http://127.0.0.1:8080
> - Browse to task instance list at http://127.0.0.1:8080/admin/taskinstance/
> - Click the Log URL book glyphicon
> - The link takes you to http://mybaseurl.com/admin/airflow/log/
> - I expect the link to go to http://127.0.0.1:8080/admin/airflow/log/



--
This message was sent by Atlassian Jira
(v8.3.2#803003)