You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/01/29 02:22:41 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #515: [Operator] Bump golang to 1.17
kaijchen opened a new pull request, #515:
URL: https://github.com/apache/incubator-uniffle/pull/515
### What changes were proposed in this pull request?
Bump go version of `deploy/kubernetes/operator` to 1.17.
### Why are the changes needed?
Fix #512.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407545801
> > Let's address the golang issue in #491 ?
> > I have updated the related files, and it should be passing.
>
> It won't work if you don't change go version in go.mod
Yeah，I found that and it’s also addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407544747
Let's address the golang issue in #491 ?
I have updated the related files, and it should be passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407543362
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#515](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efe23cf) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/3ba56c5496f39032cd723906e1776ec129d3cc01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ba56c5) will **decrease** coverage by `0.47%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #515 +/- ##
============================================
- Coverage 59.75% 59.29% -0.47%
+ Complexity 1765 1547 -218
============================================
Files 205 183 -22
Lines 11527 9694 -1833
Branches 1033 874 -159
============================================
- Hits 6888 5748 -1140
+ Misses 4233 3583 -650
+ Partials 406 363 -43
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../hadoop/mapreduce/task/reduce/RssBypassWriter.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0J5cGFzc1dyaXRlci5qYXZh) | | |
| [...ava/org/apache/spark/shuffle/RssShuffleHandle.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTaHVmZmxlSGFuZGxlLmphdmE=) | | |
| [...org/apache/spark/shuffle/RssSparkShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya1NodWZmbGVVdGlscy5qYXZh) | | |
| [...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL1Jzc01SVXRpbHMuamF2YQ==) | | |
| [...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3YyL2FwcC9Sc3NNUkFwcE1hc3Rlci5qYXZh) | | |
| [.../java/org/apache/hadoop/mapreduce/RssMRConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL1Jzc01SQ29uZmlnLmphdmE=) | | |
| [...rg/apache/hadoop/mapred/RssMapOutputCollector.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkL1Jzc01hcE91dHB1dENvbGxlY3Rvci5qYXZh) | | |
| [...mapreduce/task/reduce/RssInMemoryRemoteMerger.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0luTWVtb3J5UmVtb3RlTWVyZ2VyLmphdmE=) | | |
| [...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL01SSWRIZWxwZXIuamF2YQ==) | | |
| [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-uniffle/pull/515?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407551867
> I'm ok to change the PR/commit title.
>
> But after a second thought, it could be better to merge this quickly. This is the simplest fix and it has the same effect/result as disable k8s ut temporary. We could address other related changes in followup pr or in #491.
>
> Let's merge this quickly then? @kaijchen @zuston
Sure, thanks for the review. Bumping the golang version is a quick fix here.
To fully address the problem, we should find a way to anchor versions of the transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407550494
> > > Yeah，I found that and it’s also addressed.
> >
> >
> > Sorry, I didn't see that. However, I don't think "better **build system** support" should change the go version of a project. Maybe find a better title or just do one thing at a time?
>
> We could push forward this PR quickly to avoid CI failure later
If we are going to avoid CI failure. We should disable the go/k8s UT temporally. And enables it as soon as the build issue is addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407551409
> > Yeah，I found that and it’s also addressed.
>
> Sorry, I didn't see that. However, I don't think "better **build system** support" should change the go version of a project. Maybe find a better title or just do one thing at a time?
I'm ok to change the PR/commit title.
But after a second thought, it could be better to merge this quickly. This is the simplest fix and it has the same effect/result as disable k8s ut temporary. We could address other related changes in followup pr or in #491.
Let's merge this quickly then? @kaijchen @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407573589
> > It won't work if you don't change go version in go.mod
>
> Sorry I forgot to include the go.mod bump in this PR. Seems it works without changing go version in go.mod.
I have addressed that in https://github.com/apache/incubator-uniffle/pull/491
Without change go version in go.mod, means that the go program is compiled by go 1.17, but the minimal go version in this project is still go 1.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407550313
> > Yeah，I found that and it’s also addressed.
>
> Sorry, I didn't see that. However, I don't think "better **build system** support" should change the go version of a project. Maybe find a better title or just do one thing at a time?
Yeah, I'm for do one thing at a time, so in the previous comment https://github.com/apache/incubator-uniffle/pull/491#discussion_r1071936670 . I was planning to upgrade the go version to 1.17 in a follow up pr.
But the ci build issue raised and I thought it could be addressed in one pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] wangao1236 commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "wangao1236 (via GitHub)" <gi...@apache.org>.
wangao1236 commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407543788
What is the specific smaller version of the previous golang? My local version is go-1.16.15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407552677
> To fully address the problem, we should find a way to anchor versions of the transitive dependencies.
We could anchor versions in `go.mod`, but in practice, it often goes out of control when more than 3-5 deps are anchored.
It's best practice to upgrade go runtime and libs if necessary. Also, the operator is build as an image, and the compiled go binary doesn't require go runtime to be included, it should be safe to upgrade go runtime and won't cause downstream users too much trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407547227
> > Yeah，I found that and it’s also addressed.
>
> Sorry, I didn't see that. However, I don't think "better **build system** support" should change the go version of a project. Maybe find a better title or just do one thing at a time?
We could push forward this PR quickly to avoid CI failure later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407546754
> Yeah，I found that and it’s also addressed.
Sorry, I didn't see that. However, I don't think "better **build system** support" should change the go version of a project.
Maybe find a better title or just do one thing at a time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407544670
> What is the specific smaller version of the previous golang? My local version is go-1.16.15.
The revision doesn't matter. The new interface was introduced in go std library 1.17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407544886
> Let's address the golang issue in #491 ?
>
> I have updated the related files, and it should be passing.
It won't work if you don't change go version in go.mod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407554397
Thanks @advancedxy and @zuston for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #515: [ISSUE-512][Operator] Bump golang to 1.17
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #515:
URL: https://github.com/apache/incubator-uniffle/pull/515#issuecomment-1407562540
> It won't work if you don't change go version in go.mod
Sorry I forgot to include the go.mod bump in this PR.
Seems it works without changing go version in go.mod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org