[jira] [Commented] (BAHIR-152) License header not enforced for Java sources

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BAHIR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285199#comment-16285199 ] 

ASF GitHub Bot commented on BAHIR-152:
--------------------------------------

GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/58

    [BAHIR-152] Enforce License Header in Java Sources

    [BAHIR-152: License header not enforced for Java sources](https://issues.apache.org/jira/browse/BAHIR-152)
    
    Add a `Header` rule to the `checkstyle` configuration to enforce proper
    Apache license headers in `*.java` source files.
    
    A similar `HeaderMatchesChecker` rule already exists in the `scalastyle`
    configuration to enforce the license headers in `*.scala` source files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir BAHIR-152_java_license_header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 245db8fc6b45ede6a4a2d3be9740e50a20a29a33
Author: Christian Kadner <ck...@apache.org>
Date:   2017-12-10T11:15:04Z

    [BAHIR-152] Enforce License Header in Java Sources
    
    Add a "Header" rule to the checkstyle configuration to enforce proper
    Apache license headers in Java source files.
    A similar rule ("HeaderMatchesChecker") already exists in the scalastyle
    configuration.
    
    Closes #58

----


> License header not enforced for Java sources
> --------------------------------------------
>
>                 Key: BAHIR-152
>                 URL: https://issues.apache.org/jira/browse/BAHIR-152
>             Project: Bahir
>          Issue Type: Bug
>          Components: Build, Spark SQL Data Sources, Spark Streaming Connectors, Spark Structured Streaming Connectors
>    Affects Versions: Not Applicable
>            Reporter: Christian Kadner
>            Assignee: Christian Kadner
>             Fix For: Spark-2.2.1, Spark-2.3
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In any Java source file add this line on top of the license header:
> {code}
> /*
>  * Copyright (c) 2017 ACME. All rights reserved.
>  * <p>
> {code}
> then run {{mvn clean verify}} and see the build succeed.
> Neither of the following maven goals complains either:
>  - {{mvn apache-rat:check}}
>  - {{mvn checkstyle:check}}
> Adding a similar copyright statement to any of the Scala sources will fail the {{HeaderMatchesChecker}} rule in our {{scalastyle}} checks.
> I am not sure why the [RAT|http://creadur.apache.org/rat/apache-rat-plugin/usage.html] checks allow this to pass, but I will add a similar {{Header}} verification to our {{checkstyle}} configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)