[jira] [Commented] (GEODE-5259) DataSerializable objects should not have fixed ClassId properties

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619806#comment-16619806 ] 

ASF subversion and git services commented on GEODE-5259:
--------------------------------------------------------

Commit 9a8751fb8f71686d439dca27e5fdc9fc9ed70836 in geode-native's branch refs/heads/develop from [~mmartell]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=9a8751f ]

GEODE-5259: Remove classId from DataSerializable

- Test using type_info
- First cut at removing getClassId() from DataSerializable
- Switch to find instead of [ ] operator
- Update clicache integration tests to use new DataSerializable interface.
- Added new CSharp serialization test.
- Removed all reference to ClassId and added "type" to the Managed wrapper of DataSerializables plus tests
- Rebased with develop: switch to DSCode
- Make the DSCode version of bind private
- Cleanup bind function
- Fix serialize (wasn't writing the DSCode and the user typeId).
- Added a composite custom object test
- Update tests to use proper typeId (to match java classes).
- Update clicache integration tests to use new DataSerializable interface.
- Added new CSharp serialization test.
- Removed all reference to ClassId and added "type" to the Managed wrapper of DataSerializables plus tests
- Make the DSCode version of bind private
- Added a composite custom object test
- Update tests to use proper typeId (to match java classes).
- Switch TypeId for Portfolio and Position in clicache tests to coorespond with the Java versions of each.
- Updated DataSerializable test to use explicit compares of strings
- changed uint32_t to int32_t in TypeRegistry
- Refactor to remove compID (composite ID) and use better naming of maps
  All id's are now int32_t and bit shifts were removed
- Copy geode-native symbols to allow debugging
- Refactor bind into bindDataSerializable and bindDataSerializableFixedId and rename maps
- Switch back to std::type_info
- Added ManagedDataSerializableHandler support.
- Intercepting handling of DataSerializables for managed and unmanaged.
- Refactored SerializationRegistry to collapse overloaded methods.
- Added helper methods to support the (de)serializtion methods.
- DataOutput api changed to only support std::shared_ptr<Serializable>
- Managed TypeRegistry has improved mnemonics of maps and accessors
- also removed obsolete native delegate creation
- Only copy the pdb for Debug builds
- Test code shouldn't eat exceptions when creating the cache.
- Split out DataSerializablePrimitives map.
- Refactored map names to be more expressive.
- Remove DataSerializableInternal::getInternal().
- Fix rename error of DSCodeToFactoryMap
- Fix and reformat clicache SerializationTests
- Update examples to new DataSerializable api
- Fix missing Type property in example code
- Just use System::Type in IDataSerializable
- Cleanup formatting and dead code
- Remove IDataSerializable::Type property (no longer needed)
- More file cleanup from review.
- Remove Type property from an example.


> DataSerializable objects should not have fixed ClassId properties
> -----------------------------------------------------------------
>
>                 Key: GEODE-5259
>                 URL: https://issues.apache.org/jira/browse/GEODE-5259
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> Like the Java version of these classes the ClassId should be registered with the Class and on a per Cache/DS basis. 
>  
> Remove ClassId from DataSerializable and add it to the TypeRegistry::RegisteryType call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)