You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/11/17 06:42:54 UTC
[GitHub] [tinkerpop] Liu-Delin opened a new pull request #1359: TINKERPOP-2475 Barrier step touches one more element of next loop
Liu-Delin opened a new pull request #1359:
URL: https://github.com/apache/tinkerpop/pull/1359
https://issues.apache.org/jira/browse/TINKERPOP-2475
This bug will preload one more element in barrier action. For example, if we have 4 vertices, and we have a barrier(2) step, we expect to get the first 2 in a barrier then the last 2 in another barrier loop. But when we get the first 2 vertices, the third one has already been loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya commented on pull request #1359: TINKERPOP-2475 Barrier step touches one more element of next loop
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on pull request #1359:
URL: https://github.com/apache/tinkerpop/pull/1359#issuecomment-729273911
Congratulations and thank you @Liu-Delin for your first contribution to Apache TinkerPop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1359: TINKERPOP-2475 Barrier step touches one more element of next loop
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1359:
URL: https://github.com/apache/tinkerpop/pull/1359#issuecomment-729203661
This is a good change. There's no reason I can think of to `hasNext()` before checking the barrier limit. Cherry-picked and merged as CTR: 325d772d9be02bc51dbf1bb5efda37541ad47bd6
Thanks you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1359: TINKERPOP-2475 Barrier step touches one more element of next loop
Posted by GitBox <gi...@apache.org>.
spmallette closed pull request #1359:
URL: https://github.com/apache/tinkerpop/pull/1359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org