[GitHub] gengliangwang edited a comment on issue #23310: [SPARK-26363][WebUI] Avoid duplicated KV store lookups for task table

[GitBox <gi...@apache.org>]

gengliangwang edited a comment on issue #23310: [SPARK-26363][WebUI] Avoid duplicated KV store lookups for task table
URL: https://github.com/apache/spark/pull/23310#issuecomment-447396268
 
 
   @tgravescs I found the issue when I merge the code changes to our product. I don't try it in large application to get performance difference. Performance is not the key motivation. We can use a hash map to reduce the number of KV store lookups.
   
   The main point of this PR is about the data structure `TaskData` should not conclude the field `executorLogs`, which is redundant and not belong to the scope of task data.
   I can understand your concern about less output on server side. IMO it is quite minor to show the executor log column in task table, since the executor table in stage page/executor page already has it.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org