You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by aefox <gi...@git.apache.org> on 2016/12/05 20:35:23 UTC
[GitHub] camel pull request #1332: CAMEL-10086 added GenericFileEndpoint.(include|exc...
GitHub user aefox opened a pull request:
https://github.com/apache/camel/pull/1332
CAMEL-10086 added GenericFileEndpoint.(include|exclude)Pattern for a \u2026
\u2026better reusage
This is part 2 of [CAMEL-10086](https://issues.apache.org/jira/browse/CAMEL-10086).
It follows on the suggestion from the ticket description:
`GenericFileEndpoint could contain also excludePattern as well.`
Please note couple of things:
1) This PR might not be considered complete because:
- I'm not sure if javadoc should be added on the new methods in `GenericFileEndpoint`
- Also I have only checked that the existing tests work as before and didn't investigate if/what needs to be updated
- Any suggestions related to the above 2 lines would be appreciated
2) I have raised this PR to get a validation that this approach is good and can continue in this direction
3) This PR also contains some other cleanup that I noticed could be done
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aefox/camel CAMEL-10086
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1332
----
commit 12be6a2f56877546e5ae446f4450150336a1715c
Author: aefox <al...@gmail.com>
Date: 2016-12-05T20:15:28Z
CAMEL-10086 added GenericFileEndpoint.(include|exclude)Pattern for a better reusage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request #1332: CAMEL-10086 added GenericFileEndpoint.(include|exc...
Posted by aefox <gi...@git.apache.org>.
Github user aefox closed the pull request at:
https://github.com/apache/camel/pull/1332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---