You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dianfu <gi...@git.apache.org> on 2017/08/18 12:56:36 UTC
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4563
[FLINK-7479] [cep] Support to retrieve the past event by an offset
## What is the purpose of the change
*Currently, it's already able to retrieve events matched to the specifed pattern in IterativeCondition.Context. While there are also requirements to retrieve events by an physical offset. The retrieved events may not be matched to any pattern.*
## Brief change log
- *Add API retain() in Pattern*
- *Buffer the past events in NFA.process*
- *Access the past events by the newly added API getEventByOffset in IterativeCondition.Context*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test in IterativeConditionsITCase*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs / JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dianfu/flink FLINK-7479
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4563
----
commit e9feb55e6c2f7d32ec6266049be0ea9bbff967b2
Author: Dian Fu <fu...@alibaba-inc.com>
Date: 2017-08-18T12:50:25Z
[FLINK-7479] [cep] Support to retrieve the past event by an offset
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134158000
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -449,7 +452,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param pattern the pattern to append
* @return A new pattern which is appended to this one
*/
- def next(pattern: Pattern[T, F]): GroupPattern[T, F] =
+ def next(pattern: Pattern[T, F]) =
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157868
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -329,7 +332,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @return The same pattern as optional.
* @throws MalformedPatternException if the quantifier is not applicable to this pattern.
*/
- def optional: Pattern[T, F] = {
+ def optional = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157991
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -437,7 +440,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param pattern the pattern to append
* @return A new pattern which is appended to this one
*/
- def followedByAny(pattern: Pattern[T, F]): GroupPattern[T, F] =
+ def followedByAny(pattern: Pattern[T, F]) =
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157916
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -359,7 +362,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @return The same pattern with number of times applied
* @throws MalformedPatternException if the quantifier is not applicable to this pattern.
*/
- def times(times: Int): Pattern[T, F] = {
+ def times(times: Int) = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157798
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -269,9 +282,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param name Name of the new pattern
* @return A new pattern which is appended to this one
*/
- def next(name: String): Pattern[T, T] = {
- Pattern[T, T](jPattern.next(name))
- }
+ def next(name: String) = Pattern[T, T](jPattern.next(name))
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157831
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -305,9 +312,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param name Name of the new pattern
* @return A new pattern which is appended to this one
*/
- def notFollowedBy(name : String): Pattern[T, T] = {
- Pattern[T, T](jPattern.notFollowedBy(name))
- }
+ def notFollowedBy(name : String) = Pattern[T, T](jPattern.notFollowedBy(name))
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157810
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -280,9 +291,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param name Name of the new pattern
* @return A new pattern which is appended to this one
*/
- def notNext(name: String): Pattern[T, T] = {
- Pattern[T, T](jPattern.notNext(name))
- }
+ def notNext(name: String) = Pattern[T, T](jPattern.notNext(name))
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157969
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -426,7 +429,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param pattern the pattern to append
* @return A new pattern which is appended to this one
*/
- def followedBy(pattern: Pattern[T, F]): GroupPattern[T, F] =
+ def followedBy(pattern: Pattern[T, F]) =
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157821
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -292,9 +301,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param name Name of the new pattern
* @return A new pattern which is appended to this one
*/
- def followedBy(name: String): Pattern[T, T] = {
- Pattern[T, T](jPattern.followedBy(name))
- }
+ def followedBy(name: String) = Pattern[T, T](jPattern.followedBy(name))
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157928
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -372,7 +375,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @return The same pattern with the number of times range applied
* @throws MalformedPatternException if the quantifier is not applicable to this pattern.
*/
- def times(from: Int, to: Int): Pattern[T, F] = {
+ def times(from: Int, to: Int) = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4563: [FLINK-7479] [cep] Support to retrieve the past event by ...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4563
@dawidwys Have updated the PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157958
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -413,7 +416,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* By default a relaxed continuity is applied.
* @return pattern with continuity changed to strict
*/
- def consecutive(): Pattern[T, F] = {
+ def consecutive() = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157941
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -390,7 +393,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @return The same pattern with the updated quantifier.
* @throws MalformedPatternException if the quantifier is not applicable to this pattern.
*/
- def allowCombinations(): Pattern[T, F] = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157893
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -347,7 +350,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @return The same pattern with a [[Quantifier.oneOrMore()]] quantifier applied.
* @throws MalformedPatternException if the quantifier is not applicable to this pattern.
*/
- def oneOrMore: Pattern[T, F] = {
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4563: [FLINK-7479] [cep] Support to retrieve the past event by ...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4563
Thanks @dawidwys for the suggestion. I will update the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4563: [FLINK-7479] [cep] Support to retrieve the past ev...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4563#discussion_r134157849
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala ---
@@ -317,9 +322,7 @@ class Pattern[T , F <: T](jPattern: JPattern[T, F]) {
* @param name Name of the new pattern
* @return A new pattern which is appended to this one
*/
- def followedByAny(name: String): Pattern[T, T] = {
- Pattern[T, T](jPattern.followedByAny(name))
- }
+ def followedByAny(name: String) = Pattern[T, T](jPattern.followedByAny(name))
--- End diff --
Unrelated change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---