You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/01 20:50:17 UTC

[GitHub] [arrow] wesm commented on a change in pull request #8314: ARROW-10147: [Python] Pandas metadata fails if index name not JSON-serializable

wesm commented on a change in pull request #8314:
URL: https://github.com/apache/arrow/pull/8314#discussion_r498505600



##########
File path: python/pyarrow/pandas_compat.py
##########
@@ -470,7 +470,7 @@ def _get_range_index_descriptor(level):
     # public start/stop/step attributes added in pandas 0.25.0
     return {
         'kind': 'range',
-        'name': level.name,
+        'name': str(level.name) if level.name else None,

Review comment:
       pandas allows `Index.name` to be anything -- we may want to make our best effort to try to preserve the type of the name, in the worst case pickling could be necessary




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org