You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/02/26 20:10:00 UTC
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1727
[FLINK-3526] [streaming] Fix Processing Time Window Assigner and Trigger
Fixed the processing time window assigner to use actual processing time
Fixed the processing time trigger to fire after the window, not on the latest element of the window.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink proc_time_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1727.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1727
----
commit be6b38eee4c6cb7caacdaa2c4f65d709d9f0de9b
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-26T19:06:06Z
[FLINK-3526] [streaming] Fix Processing Time Window Assigner and Trigger
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189444692
Trigger used unassigned event time before, but the trigger itself is only used in few cases at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189445750
It worked before because of this setProcessingTime flag in the WindowOperator that would put the current processing time into that timestamp field.
The changes look good now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189444303
Which time was the trigger using before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189447001
It was removed in the first commit that changed the interplay with StreamTimeCharacteristic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189460270
Okay, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189446394
That flag was removed during the state refactoring, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---