svn commit: r944940 - /lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java

[yo...@apache.org]

Author: yonik
Date: Sun May 16 23:48:50 2010
New Revision: 944940

URL: http://svn.apache.org/viewvc?rev=944940&view=rev
Log:
SOLR comments: add node about passing deleted docs to termsEnum

Modified:
    lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java

Modified: lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java?rev=944940&r1=944939&r2=944940&view=diff
==============================================================================
--- lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java (original)
+++ lucene/dev/trunk/solr/src/java/org/apache/solr/request/SimpleFacets.java Sun May 16 23:48:50 2010
@@ -572,6 +572,7 @@ public class SimpleFacets {
 
             // TODO: specialize when base docset is a bitset or hash set (skipDocs)?  or does it matter for this?
             // TODO: do this per-segment for better efficiency (MultiDocsEnum just uses base class impl)
+            // TODO: would passing deleted docs lead to better efficiency over checking the fastForRandomSet?
             docsEnum = termsEnum.docs(null, docsEnum);
 
             // this should be the same bulk result object if sharing of the docsEnum succeeded