[GitHub] [ozone] dombizita commented on pull request #4815: HDDS-8414. Recon: Heatmap Absolute Path in Response at end node level on HyperLink End Point Response.

["dombizita (via GitHub)" <gi...@apache.org>]

dombizita commented on PR #4815:
URL: https://github.com/apache/ozone/pull/4815#issuecomment-1572525695

   thanks for working on this @devmadhuu! overall it looks good, but based on the implementation shouldn't there be a `path` attribute for each children under bucket level (eg. in the childrens of `hivebucketTest1`) too? you set the path there too, here, right?
   https://github.com/apache/ozone/blob/1ca40abf9819d1b97c27a3617a2814af87aa5396/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/heatmap/HeatMapServiceImpl.java#L224
   I can't see it in the examples that are in the description of the PR, neither in the javadoc of the changed methods. am I missing something here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org