You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2023/01/12 18:30:02 UTC

[GitHub] [activemq-artemis] ryan-highley commented on pull request #4320: ARTEMIS-3790 Support masked JMS credentials

ryan-highley commented on PR #4320:
URL: https://github.com/apache/activemq-artemis/pull/4320#issuecomment-1380834817

   @jbertram Sorry for the delay--day job and all....
   
   That makes sense. I was attempting to move the unmasking with as little invasiveness as possible, hence the additional properties and unmask calls in the ActiveMQConnection constructor.
   
   Looking at the `o.a.a.a.jms.client.ConnectionFactoryOptions` for how `deserializationWhiteList` is implemented led me to the equivalent unmasking approach in the resource adapter, which handles the `passwordCodec` property in its ConnectionFactory as you described.
   
   I'll update this code to enable setting the codec aligning with the precedent in the RA code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org