You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 15:56:03 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
nsivabalan opened a new pull request #4003:
URL: https://github.com/apache/hudi/pull/4003
## What is the purpose of the pull request
Default value for "hoodie.metadata.enable" is false for java since metadata is not yet supported in java. Explicitly setting the default value rather than relying on default value in common which is set to true.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r750878766
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
This is what we do within getDefaultMetadataEnable(EngineType engineType).
```
case SPARK:
return ENABLE.defaultValue();
```
probably we can leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969054604
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969418676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r749896360
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
Should `ENABLE` be set with `.noDefaultValue()`? If not, engine-specific values are overwritten?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969463811
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
}, {
"hash" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397",
"triggerID" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
* d693cfa69a5b303398fb11d7d3b56b1175c14777 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969548904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
}, {
"hash" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397",
"triggerID" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
* d693cfa69a5b303398fb11d7d3b56b1175c14777 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r751718653
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r749874318
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -233,10 +237,28 @@ public Builder enableFullScan(boolean enableFullScan) {
return this;
}
+ public Builder withEngineType(EngineType engineType) {
+ this.engineType = engineType;
+ return this;
+ }
+
public HoodieMetadataConfig build() {
+ metadataConfig.setDefaultValue(ENABLE, getDefaultMetadataEnable(engineType));
metadataConfig.setDefaults(HoodieMetadataConfig.class.getName());
return metadataConfig;
}
+
+ private boolean getDefaultMetadataEnable(EngineType engineType) {
+ switch (engineType) {
+ case SPARK:
+ return ENABLE.defaultValue();
+ case FLINK:
Review comment:
flink already has a [separate config](https://github.com/apache/hudi/blob/38b6934352abd27b98332cce005f18102b388679/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java#L94) for metadata. So, by the time it reaches here, config will be set incase of filnk engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r751580015
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
I get it. but we might have to fix all tests to use the new constructor and so, don't want to fix this now. but will take it up sometime after 0.10.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969418676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969402385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969421874
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
}, {
"hash" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
* d693cfa69a5b303398fb11d7d3b56b1175c14777 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969405504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969402385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969415457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969158504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969054604
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969463811
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
}, {
"hash" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397",
"triggerID" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
* d693cfa69a5b303398fb11d7d3b56b1175c14777 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-971179209
@danny0405 : wanted to keep you in the loop on this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969057474
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969421874
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
}, {
"hash" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d693cfa69a5b303398fb11d7d3b56b1175c14777",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
* d693cfa69a5b303398fb11d7d3b56b1175c14777 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969405504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4003:
URL: https://github.com/apache/hudi/pull/4003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r751531265
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
Got it. As discussed, functionality-wise this is fine. Wondering if we can still set it with `.noDefaultValue()` instead of `.defaultValue(true)`, not to confuse developers on Java client. I'll let you decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969057474
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969158504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4003: [HUDI-2734][WIP] Setting default metadata enable as false for Java
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#issuecomment-969415457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384",
"triggerID" : "1892c70ed68c2ea6fb3a032eea7262116bd56622",
"triggerType" : "PUSH"
}, {
"hash" : "f33211a768603d63ad7a834b085346cc584d0188",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395",
"triggerID" : "f33211a768603d63ad7a834b085346cc584d0188",
"triggerType" : "PUSH"
}, {
"hash" : "2722db996ffccfc690bba36eaad6252ec738590c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2722db996ffccfc690bba36eaad6252ec738590c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1892c70ed68c2ea6fb3a032eea7262116bd56622 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3384)
* f33211a768603d63ad7a834b085346cc584d0188 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3395)
* 2722db996ffccfc690bba36eaad6252ec738590c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org