You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/01 04:39:49 UTC

[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3363: add writeThreadQueueStats

lordcheng10 commented on code in PR #3363:
URL: https://github.com/apache/bookkeeper/pull/3363#discussion_r911608343


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/RequestStats.java:
##########
@@ -92,6 +93,14 @@ public class RequestStats {
         parent = ADD_ENTRY_REQUEST
     )
     private final OpStatsLogger addEntryStats;
+
+    @StatsDoc(
+            name = WRITE_THREAD_QUEUED_LATENCY,
+            help = "operation stats of enqueuing requests to write threadpool queue",
+            parent = ADD_ENTRY_REQUEST
+    )
+    private final OpStatsLogger writeThreadQueueStats;

Review Comment:
   rename to writeThreadQueuedLatency.
   
   PTAL,thanks! @hangc0276 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org