[GitHub] [beam] lukecwik commented on a diff in pull request #25593: Add Data Sampling capability URN to Java SDK

["lukecwik (via GitHub)" <gi...@apache.org>]

lukecwik commented on code in PR #25593:
URL: https://github.com/apache/beam/pull/25593#discussion_r1114753250


##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -423,6 +423,7 @@ public static Set<String> getJavaCapabilities() {
     capabilities.add("beam:version:sdk_base:" + JAVA_SDK_HARNESS_CONTAINER_URL);
     capabilities.add(BeamUrns.getUrn(SplittableParDoComponents.TRUNCATE_SIZED_RESTRICTION));
     capabilities.add(BeamUrns.getUrn(Primitives.TO_STRING));
+    capabilities.add(BeamUrns.getUrn(RunnerApi.StandardProtocols.Enum.DATA_SAMPLING));

Review Comment:
   ```suggestion
       capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.DATA_SAMPLING));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org