You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/04/20 15:50:47 UTC
[GitHub] [orc] pgaref commented on a change in pull request #475: ORC-577 row-level filtering
pgaref commented on a change in pull request #475:
URL: https://github.com/apache/orc/pull/475#discussion_r411489293
##########
File path: java/bench/core/pom.xml
##########
@@ -112,6 +112,10 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>8</source>
Review comment:
Sure, removed from bench pom -- will be addressed be ORC-597
##########
File path: java/core/src/java/org/apache/orc/Reader.java
##########
@@ -187,6 +189,8 @@
private Boolean useZeroCopy = null;
private Boolean skipCorruptRecords = null;
private TypeDescription schema = null;
+ private String[] skipRowColumns = null;
Review comment:
Makes sense, changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org