You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Damien Katz <da...@apache.org> on 2009/05/30 19:36:19 UTC
Re: Test suite directory name (Was: Re: svn commit: r780197 - in /couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t t/030-doc-from-json.t t/031-doc-to-json.t)
I think "make test" is now broken, it doesn't run at all from a clean
source pack.
-Damien
On May 30, 2009, at 11:35 AM, Noah Slater wrote:
> On Sat, May 30, 2009 at 04:32:59PM +0100, Noah Slater wrote:
>> On Sat, May 30, 2009 at 08:22:14AM -0700, Chris Anderson wrote:
>>> maybe test/etap
>>
>> Works for me.
>
> I have moved the directory now, just some notes:
>
> * This directory has not been added to the build, and so will be
> missing from
> the release tarball.
>
> * The tests will not be run as part of "make test"
>
> Let me know when you need my help fixing these two issues.
>
> Best,
>
> --
> Noah Slater, http://tumbolia.org/nslater
Re: Test suite directory name (Was: Re: svn commit: r780197 - in
/couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t
t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t
t/030-doc-from-json.t t/031-doc-to-json.t)
Posted by Paul Davis <pa...@gmail.com>.
On Mon, Jun 1, 2009 at 10:55 AM, Nick Gerakines <ni...@gerakines.net> wrote:
> For what it's worth, that convention is being carried over from my
> Perl history and the actual directory name is completely immaterial.
Sounds like reason enough to change it ;)
> It should be noted that the etap library does assume that source files
> and beam files exist in the src and ebin directories and they are
> referenced and used when building coverage reports. Those locations
> can be overridden using an environmental variable though.
>
Now that you reminded me, there was a weird bit with getting the
coverage report to work in so much as it required also specifying the
SRC environment variable.
> # Nick Gerakines
>
> On Mon, Jun 1, 2009 at 5:13 AM, Noah Slater <ns...@apache.org> wrote:
>> On Mon, Jun 01, 2009 at 07:14:15AM +0100, Kevin Jackson wrote:
>>> > The t/* directory was just me following what I've seen as standard for
>>> > the etap layout so renaming it is perfectly fine with me.
>>>
>>> The etap documentation suggests t/* so that was following the guidelines.
>>
>> Thanks for the clarification.
>>
>> This is one of those instances I am happy to break with convention.
>>
>> Best,
>>
>> --
>> Noah Slater, http://tumbolia.org/nslater
>>
>
Re: Test suite directory name (Was: Re: svn commit: r780197 - in
/couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t
t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t
t/030-doc-from-json.t t/031-doc-to-json.t)
Posted by Nick Gerakines <ni...@gerakines.net>.
For what it's worth, that convention is being carried over from my
Perl history and the actual directory name is completely immaterial.
It should be noted that the etap library does assume that source files
and beam files exist in the src and ebin directories and they are
referenced and used when building coverage reports. Those locations
can be overridden using an environmental variable though.
# Nick Gerakines
On Mon, Jun 1, 2009 at 5:13 AM, Noah Slater <ns...@apache.org> wrote:
> On Mon, Jun 01, 2009 at 07:14:15AM +0100, Kevin Jackson wrote:
>> > The t/* directory was just me following what I've seen as standard for
>> > the etap layout so renaming it is perfectly fine with me.
>>
>> The etap documentation suggests t/* so that was following the guidelines.
>
> Thanks for the clarification.
>
> This is one of those instances I am happy to break with convention.
>
> Best,
>
> --
> Noah Slater, http://tumbolia.org/nslater
>
Re: Test suite directory name (Was: Re: svn commit: r780197 - in
/couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t
t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t
t/030-doc-from-json.t t/031-doc-to-json.t)
Posted by Noah Slater <ns...@apache.org>.
On Mon, Jun 01, 2009 at 07:14:15AM +0100, Kevin Jackson wrote:
> > The t/* directory was just me following what I've seen as standard for
> > the etap layout so renaming it is perfectly fine with me.
>
> The etap documentation suggests t/* so that was following the guidelines.
Thanks for the clarification.
This is one of those instances I am happy to break with convention.
Best,
--
Noah Slater, http://tumbolia.org/nslater
Re: Test suite directory name (Was: Re: svn commit: r780197 - in
/couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t
t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t
t/030-doc-from-json.t t/031-doc-to-json.t)
Posted by Kevin Jackson <fo...@gmail.com>.
> The t/* directory was just me following what I've seen as standard for
> the etap layout so renaming it is perfectly fine with me.
The etap documentation suggests t/* so that was following the guidelines.
Kev
Re: Test suite directory name (Was: Re: svn commit: r780197 - in
/couchdb/trunk: Makefile.am t/ t/001-load.t t/010-file-basics.t
t/011-file-headers.t t/020-btree-basics.t t/021-btree-reductions.t
t/030-doc-from-json.t t/031-doc-to-json.t)
Posted by Paul Davis <pa...@gmail.com>.
I didn't realize there was make check to begin with. Running the
tests in test/* before I always had to run them by hand.
The t/* directory was just me following what I've seen as standard for
the etap layout so renaming it is perfectly fine with me.
On Sat, May 30, 2009 at 1:36 PM, Damien Katz <da...@apache.org> wrote:
> I think "make test" is now broken, it doesn't run at all from a clean source
> pack.
>
> -Damien
>
>
> On May 30, 2009, at 11:35 AM, Noah Slater wrote:
>
>> On Sat, May 30, 2009 at 04:32:59PM +0100, Noah Slater wrote:
>>>
>>> On Sat, May 30, 2009 at 08:22:14AM -0700, Chris Anderson wrote:
>>>>
>>>> maybe test/etap
>>>
>>> Works for me.
>>
>> I have moved the directory now, just some notes:
>>
>> * This directory has not been added to the build, and so will be missing
>> from
>> the release tarball.
>>
>> * The tests will not be run as part of "make test"
>>
>> Let me know when you need my help fixing these two issues.
>>
>> Best,
>>
>> --
>> Noah Slater, http://tumbolia.org/nslater
>
>