You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/09/06 10:03:26 UTC

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4536#discussion_r137221865
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala ---
    @@ -40,17 +40,14 @@ class TableSqlFunction(
         name: String,
         udtf: TableFunction[_],
         rowTypeInfo: TypeInformation[_],
    -    returnTypeInference: SqlReturnTypeInference,
    -    operandTypeInference: SqlOperandTypeInference,
    -    operandTypeChecker: SqlOperandTypeChecker,
    -    paramTypes: util.List[RelDataType],
    +    typeFactory: FlinkTypeFactory,
         functionImpl: FlinkTableFunctionImpl[_])
       extends SqlUserDefinedTableFunction(
         new SqlIdentifier(name, SqlParserPos.ZERO),
    -    returnTypeInference,
    -    operandTypeInference,
    -    operandTypeChecker,
    -    paramTypes,
    +    ReturnTypes.CURSOR,
    +    createOperandTypeInference(name, udtf, typeFactory),
    +    createOperandTypeChecker(name, udtf),
    +    null,
    --- End diff --
    
    Is it safe to pass `null` here? Couldn't we create this parameter from `rowTypeInfo`?


---