You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/22 03:32:42 UTC
Re: Review Request 60901: Use a consistent preprocessor check for
ENABLE_PORT_MAPPING_ISOLATOR.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/#review183437
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 16, 2017, 11:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60901/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 11:42 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There's no need to also check for Windows when testing the
> ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
> ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
> Linux-specific features.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/60901/diff/4/
>
>
> Testing
> -------
>
> make check (Frdora 26).
>
>
> Thanks,
>
> James Peach
>
>