You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/07 02:18:00 UTC
[GitHub] [pulsar] tuteng opened a new pull request #14135: [cpp][pulsar-client]Add auth http headers
tuteng opened a new pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
On the broker side, `X-Pulsar-Auth-Method` https://github.com/apache/pulsar/blob/4dcb166e0bfcce7fc85fd8d59a25b881f6f9c6fa/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java#L90 is currently used to determine the authentication method of the client, so add the auth method header for the cpp client
### Modifications
* Add header `X-Pulsar-Auth-Method-Name`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuteng removed a comment on pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
tuteng removed a comment on pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135#issuecomment-1031029126
The authentication status of the pulsar protocol does not need this fix, so disabled it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135#issuecomment-1053855293
Hi @tuteng seems that this PR does not affect docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuteng commented on pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
tuteng commented on pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135#issuecomment-1031029126
The authentication status of the pulsar protocol does not need this fix, so disabled it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135#issuecomment-1031178567
@tuteng when submitting a PR, can you provide doc-related info (tick the box) in the [PR description](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation)? So that Bot can recognize and label your PR correspondingly. Or else Bot labels your PR with `doc-info-missing`.
Instructions of doc labels: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#bookmark=id.5d66olk7l4oz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuteng closed pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
tuteng closed pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14135: [cpp][pulsar-client]Add auth http headers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14135:
URL: https://github.com/apache/pulsar/pull/14135#issuecomment-1031007690
@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org