You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/07 09:53:48 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #8899: [fix]predicate propagate was removed incautiously
morrySnow opened a new pull request, #8899:
URL: https://github.com/apache/incubator-doris/pull/8899
# Proposed changes
Issue Number: close #8892
## Problem Summary:
predicate propagate was removed incautiously by #7357
https://github.com/apache/incubator-doris/pull/7357/files#diff-29c38bc01155697542b0b97108fa6fd91d698ec370ef66a666693f33fea92bd4L1703
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #8899:
URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r846252706
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##########
@@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, TableRef tblRef, SelectStmt s
break;
}
if (scanNode instanceof OlapScanNode || scanNode instanceof EsScanNode || scanNode instanceof HiveScanNode) {
+ PredicatePushDown.visitScanNode(scanNode, tblRef.getJoinOp(), analyzer);
Review Comment:
If it's a temporary fix, I don't think it should be merged into the trunk.
And we can give users a temporary fix release to solve their problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8899:
URL: https://github.com/apache/incubator-doris/pull/8899#issuecomment-1091770220
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #8899:
URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r845877637
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##########
@@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, TableRef tblRef, SelectStmt s
break;
}
if (scanNode instanceof OlapScanNode || scanNode instanceof EsScanNode || scanNode instanceof HiveScanNode) {
+ PredicatePushDown.visitScanNode(scanNode, tblRef.getJoinOp(), analyzer);
Review Comment:
yes, u r right, but we need a quick fix for predicate propagate before fix the 'InferFiltersRule' since there is 10 times slower in specific scene. i will fix 'InferFiltersRule' later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #8899:
URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r845718306
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##########
@@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, TableRef tblRef, SelectStmt s
break;
}
if (scanNode instanceof OlapScanNode || scanNode instanceof EsScanNode || scanNode instanceof HiveScanNode) {
+ PredicatePushDown.visitScanNode(scanNode, tblRef.getJoinOp(), analyzer);
Review Comment:
You should fix the 'InferFiltersRule' rather than add visit in here ~
The logic of `predicate propagate` in the 'InferFiltersRule'.
The 'Predicate Push Down' is the abandoned logic ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #8899:
URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r846799287
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##########
@@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, TableRef tblRef, SelectStmt s
break;
}
if (scanNode instanceof OlapScanNode || scanNode instanceof EsScanNode || scanNode instanceof HiveScanNode) {
+ PredicatePushDown.visitScanNode(scanNode, tblRef.getJoinOp(), analyzer);
Review Comment:
that's ok for this case. but I strongly recommend not removing any performance-related features until alternatives are fully developed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow closed pull request #8899: [fix]predicate propagate was removed incautiously
Posted by GitBox <gi...@apache.org>.
morrySnow closed pull request #8899: [fix]predicate propagate was removed incautiously
URL: https://github.com/apache/incubator-doris/pull/8899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org