You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/25 09:53:31 UTC

[GitHub] [age] Munmud opened a new pull request, #422: docker Instruction added for accessing Postgres shell

Munmud opened a new pull request, #422:
URL: https://github.com/apache/age/pull/422

   ## Instruction Added
   - Run docker container
   - Access CLI for age container 
   - Access Postgres shell
   
   ## Removed
   - Unnecessary new line in previous bash command


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] Munmud commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
Munmud commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1057255969


##########
README.md:
##########
@@ -180,9 +179,8 @@ make PG_CONFIG=/path/to/postgres/bin/pg_config install
 
 ```bash
 docker pull apache/age
-
 ```
-<h5> Create AGE docker container </h5>
+<h5> Create age docker container for first time</h5>

Review Comment:
   the container name is case sensitive... Container won't run otherwise



##########
README.md:
##########
@@ -195,7 +193,23 @@ docker run \
     apache/age
 ```
 
+<h5> Or Run docker container if you previously worked with age container </h5>

Review Comment:
   the container name is case sensitive... Container won't run otherwise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] GhostVaibhav commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1057327007


##########
README.md:
##########
@@ -180,9 +179,8 @@ make PG_CONFIG=/path/to/postgres/bin/pg_config install
 
 ```bash
 docker pull apache/age
-
 ```
-<h5> Create AGE docker container </h5>
+<h5> Create age docker container for first time</h5>

Review Comment:
   This is the title, affecting the case of the alphabet won't make any difference in the running of the code. The case-sensitive line is 193 specifying the image to pull.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] Munmud commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
Munmud commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1057372674


##########
README.md:
##########
@@ -195,7 +193,23 @@ docker run \
     apache/age
 ```
 
+<h5> Or Run docker container if you previously worked with age container </h5>

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] GhostVaibhav commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1057327412


##########
README.md:
##########
@@ -195,7 +193,23 @@ docker run \
     apache/age
 ```
 
+<h5> Or Run docker container if you previously worked with age container </h5>

Review Comment:
   This is only a task description so you can capitalize the alphabet here. The main script is line 199 which should be case sensitive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] GhostVaibhav commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1056959773


##########
README.md:
##########
@@ -180,9 +179,8 @@ make PG_CONFIG=/path/to/postgres/bin/pg_config install
 
 ```bash
 docker pull apache/age
-
 ```
-<h5> Create AGE docker container </h5>
+<h5> Create age docker container for first time</h5>

Review Comment:
   You can capitalize the `age` word here as it holds significance



##########
README.md:
##########
@@ -195,7 +193,23 @@ docker run \
     apache/age
 ```
 
+<h5> Or Run docker container if you previously worked with age container </h5>

Review Comment:
   Also, capitalize the `age` keyword here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] Munmud commented on a diff in pull request #422: docker Instruction added for accessing Postgres shell

Posted by GitBox <gi...@apache.org>.
Munmud commented on code in PR #422:
URL: https://github.com/apache/age/pull/422#discussion_r1057372712


##########
README.md:
##########
@@ -180,9 +179,8 @@ make PG_CONFIG=/path/to/postgres/bin/pg_config install
 
 ```bash
 docker pull apache/age
-
 ```
-<h5> Create AGE docker container </h5>
+<h5> Create age docker container for first time</h5>

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org