You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/27 15:07:54 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #981: MINIFICPP-1461 Enable Curl dependent expression language tests on Windows (mini-PR)

lordgamez opened a new pull request #981:
URL: https://github.com/apache/nifi-minifi-cpp/pull/981


   After merging the changes of MINIFICPP-1446 in #973, there should be no problems anymore from compiling and running EL tests using CURL library features on Windows.
   
   -------------------------------------------------------------------
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #981: MINIFICPP-1461 Enable Curl dependent expression language tests on Windows (mini-PR)

Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #981:
URL: https://github.com/apache/nifi-minifi-cpp/pull/981


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #981: MINIFICPP-1461 Enable Curl dependent expression language tests on Windows (mini-PR)

Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #981:
URL: https://github.com/apache/nifi-minifi-cpp/pull/981#issuecomment-768961678


   > Currently all expression language-related tests (unit and integration) are disabled in Windows builds in the cmake file:
   > 
   > https://github.com/apache/nifi-minifi-cpp/blob/f2fd698504c0cba9e024d4a3a5868a374ba18b5e/extensions/expression-language/tests/CMakeLists.txt#L24
   > 
   > https://github.com/apache/nifi-minifi-cpp/blob/f2fd698504c0cba9e024d4a3a5868a374ba18b5e/extensions/expression-language/tests/CMakeLists.txt#L50
   > 
   > so this change will have no effect.
   
   Thanks for the heads up! After compiling and running it locally it seems that there are multiple problems with the tests on Windows from different rounding of values to missing resources, which need to be fixed before it can be re-enabled. I'll update the Jira issue and close this PR, we can return to this issue later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org