You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/16 05:19:42 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #17108: [imp][managed-ledger] Optimize getting ledger and entry id from entry

michaeljmarshall opened a new pull request, #17108:
URL: https://github.com/apache/pulsar/pull/17108

   ### Motivation
   
   Minor optimization. The implementation of `getPosition` involves creating a `PositionImpl` object. We don't need to create that object because we have access to the `ledgerId` and the `entryId`.
   
   https://github.com/apache/pulsar/blob/76f41957d3b388d62067704ceb1b693dbd3e372d/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java#L134-L137
   
   ### Modifications
   
   * Remove unnecessary `getPosition()` call.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Documentation
   
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #17108: [imp][managed-ledger] Optimize getting ledger and entry id from entry

Posted by GitBox <gi...@apache.org>.

merlimat merged PR #17108:
URL: https://github.com/apache/pulsar/pull/17108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org