You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/15 10:06:33 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2339: HDDS-5348. Pipeline creator may miss one-shot run

adoroszlai opened a new pull request #2339:
URL: https://github.com/apache/ozone/pull/2339


   ## What changes were proposed in this pull request?
   
   If `BackgroundPipelineCreatorV2` tries to trigger one-shot run while pipeline creation is in progress (before entering `wait()`), then its `notifyAll()` call is lost.  This can result in unnecessary wait, as it will only check if it needs to run after the wait is over.
   
   I think this may contribute to tests timing out waiting for SCM safemode exit.
   
   This change adds a simple check for one-shot run flag before entering wait.
   
   https://issues.apache.org/jira/browse/HDDS-5348
   
   ## How was this patch tested?
   
   Repeated some integration tests that have been failing recently.
   
   10x `TestOzoneManagerConfiguration` and `TestOzoneFileInterfaces`:
   https://github.com/adoroszlai/hadoop-ozone/runs/2826594684
   
   10x `TestOzoneManagerHA*`:
   https://github.com/adoroszlai/hadoop-ozone/runs/2826131709
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/938502573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org