You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (Jira)" <ji...@apache.org> on 2022/01/10 00:53:00 UTC

[jira] [Resolved] (SPARK-37835) Fix the comments on SQLQueryTestSuite.scala/ThriftServerQueryTestSuite.scala to more explicit

     [ https://issues.apache.org/jira/browse/SPARK-37835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-37835.
----------------------------------
    Fix Version/s: 3.3.0
         Assignee: Haejoon Lee
       Resolution: Fixed

Fixed in https://github.com/apache/spark/pull/35129

> Fix the comments on SQLQueryTestSuite.scala/ThriftServerQueryTestSuite.scala to more explicit
> ---------------------------------------------------------------------------------------------
>
>                 Key: SPARK-37835
>                 URL: https://issues.apache.org/jira/browse/SPARK-37835
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.3.0
>            Reporter: Haejoon Lee
>            Assignee: Haejoon Lee
>            Priority: Major
>             Fix For: 3.3.0
>
>
> Currently, the comments on `SQLQueryTestSuite.scala` says:
> {code:java}
>  * To re-generate golden files for entire suite, run:
>  * {{{
>  *   SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite" 
>  * }}} {code}
> But we have only `org.apache.spark.sql.SQLQueryTestSuite` for `*SQLQueryTestSuite`, so we'd better to recommend to use `org.apache.spark.sql.SQLQueryTestSuite` explicitly.
> Also same for `ThriftServerQueryTestSuite.scala`.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org